ts_time: make Handle an actually strong handle that cancels on drop - #385
Merged
Conversation
You can now forget() a handle to drop the Handle without canceling the event (at which point the event will fire unconditionally when its time is up). You can also Scheduler::add_uncancelable as a more obvious version of add(...).forget(). Also remove reschedule(), since it's hard to use ergonomically and has no performance benefit over just canceling and adding a new event. Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: Icc5e025e8b0ea4f81ca822c9177ecd3e6a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now forget() a handle to drop the Handle without canceling the event (at which point the event will fire unconditionally when its time is up). You can also Scheduler::add_uncancelable as a more obvious version of add(...).forget().
Also remove reschedule(), since it's hard to use ergonomically and has no performance benefit over just canceling and adding a new event.
Change-Id: Icc5e025e8b0ea4f81ca822c9177ecd3e6a6a6964